Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix access to logger attribute when multiple loggers are used #14234

Merged
merged 4 commits into from
Aug 18, 2022
Merged

Fix access to logger attribute when multiple loggers are used #14234

merged 4 commits into from
Aug 18, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Aug 16, 2022 •
edited by github-actions bot
Loading

What does this PR do?

Fixes #14231

To be included in 1.7.x. The code we fix here will also be removed later on as part of the deprecation ending in 1.8.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @awaelchli @edward-io @Borda @ananthsub @rohitgr7 @kamil-kaczmarek @Raalsky @Blaizzy @carmocca @justusschock @ninginthecloud @jjenniferdai

@awaelchli awaelchli added bug Something isn't working logger Related to the Loggers lightningmodule pl.LightningModule labels Aug 16, 2022
@awaelchli awaelchli added this to the pl:1.7.x milestone Aug 16, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 16, 2022
@awaelchli awaelchli self-assigned this Aug 16, 2022
@awaelchli awaelchli marked this pull request as ready for review August 16, 2022 19:14
@awaelchli awaelchli force-pushed the bugfix/logger-attributeerror branch from 1882817 to 1f681b3 Compare August 16, 2022 19:15
@mergify mergify bot added ready PRs ready to be merged has conflicts and removed ready PRs ready to be merged labels Aug 17, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Aug 17, 2022
@awaelchli awaelchli enabled auto-merge (squash) August 17, 2022 18:35
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Aug 18, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Aug 18, 2022
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #14234 (5880e28) into master (047f0aa) will decrease coverage by 9%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #14234     +/-   ##
=========================================
- Coverage      85%      76%     -9%     
=========================================
  Files         330      330             
  Lines       26760    26761      +1     
=========================================
- Hits        22797    20348   -2449     
- Misses       3963     6413   +2450

@lexierule lexierule disabled auto-merge August 18, 2022 12:55
@lexierule lexierule merged commit 7879628 into master Aug 18, 2022
@lexierule lexierule deleted the bugfix/logger-attributeerror branch August 18, 2022 12:55
awaelchli added a commit that referenced this pull request Aug 18, 2022
@awaelchli
Fix access to logger attribute when multiple loggers are used (#14234)
987dd54 
* Fix access to logger attribute when multiple loggers are used
nicolai86 pushed a commit that referenced this pull request Aug 23, 2022
@awaelchli @nicolai86
Fix access to logger attribute when multiple loggers are used (#14234)
cec79c8 
* Fix access to logger attribute when multiple loggers are used

* add changelog
lexierule pushed a commit that referenced this pull request Aug 25, 2022
@awaelchli @lexierule
Fix access to logger attribute when multiple loggers are used (#14234)
ae6bd3f 
* Fix access to logger attribute when multiple loggers are used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@carmocca carmocca carmocca approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

Assignees

@awaelchli awaelchli

Labels
bug Something isn't working lightningmodule pl.LightningModule logger Related to the Loggers pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
No open projects
Frameworks Planning
Status: Done
Milestone
pl:1.7.x
Development

Successfully merging this pull request may close these issues.

Wrong warnings module used in lightning module
4 participants
@awaelchli @carmocca @rohitgr7 @lexierule